Skip to content

DAOS-17973 control: Allow none for pool property self_heal (#16848) #17217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
liw wants to merge 1 commit into
base: release/2.6
Choose a base branch
from
Draft

DAOS-17973 control: Allow none for pool property self_heal (#16848) #17217

liw wants to merge 1 commit into from
+21 −3

Conversation

@liw
Copy link
Contributor

@liw liw commented Dec 3, 2025

It is impossible to turn off all flags of pool property self_heal, because dmg pool set-prop disallows empty value syntax. This patch adds "none" as a valid value for pool property self_heal, to indicate that all flags are turned off.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@liw liw added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Dec 3, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Ticket title is 'dmg set-prop self_heal should be able to accept empty string value'
Status is 'Awaiting backport'
Labels: 'scrubbed_2.6.5'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-17973

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Dec 3, 2025
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 3, 2025

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17217/1/testReport/

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 3, 2025

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17217/2/testReport/

@liw liw force-pushed the liw/fix-empty-self_heal-ii-2.6 branch from 68614e6 to 6cb808d Compare December 7, 2025 23:45
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 8, 2025

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17217/3/testReport/

@liw liw force-pushed the liw/fix-empty-self_heal-ii-2.6 branch from 6cb808d to 449a2b2 Compare December 15, 2025 00:08
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 15, 2025

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17217/4/execution/node/1530/log

@liw liw force-pushed the liw/fix-empty-self_heal-ii-2.6 branch from 449a2b2 to ee0644a Compare December 24, 2025 04:55
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 24, 2025

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17217/5/testReport/

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 24, 2025

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17217/5/execution/node/1523/log

@liw liw force-pushed the liw/fix-empty-self_heal-ii-2.6 branch from ee0644a to fdc8bc7 Compare January 6, 2026 04:41
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Jan 6, 2026

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17217/6/testReport/

@liw liw force-pushed the liw/fix-empty-self_heal-ii-2.6 branch from fdc8bc7 to a0b9e30 Compare January 7, 2026 02:34
@liw
DAOS-17973 control: Allow none for pool property self_heal (#16848)
cd66fa0 
It is impossible to turn off all flags of pool property self_heal,
because dmg pool set-prop disallows empty value syntax. This patch adds
"none" as a valid value for pool property self_heal, to indicate that
all flags are turned off.

Signed-off-by: Li Wei <[email protected]>
@liw liw force-pushed the liw/fix-empty-self_heal-ii-2.6 branch from a0b9e30 to cd66fa0 Compare January 15, 2026 02:56
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Jan 15, 2026

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17217/8/testReport/

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Jan 15, 2026

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17217/8/execution/node/1577/log

@liw
Copy link
Contributor Author

liw commented Jan 19, 2026

Needs to wait for #17401.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

clean-cherry-pick Cherry-pick from another branch that did not require additional edits priority Ticket has high priority (automatically managed)

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liw @daosbuild3